Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Aarch64 imx8 crosscompile kvms #8

Open
wants to merge 9 commits into
base: aarch64-imx8-crosscompile
Choose a base branch
from

Conversation

grihey
Copy link

@grihey grihey commented Sep 14, 2022

Description of changes
Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.11 Release Notes (or backporting 22.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

From e83aaa5788a779cae1e28f976a624647ee2fa0fa Mon Sep 17 00:00:00 2001
From: Janne Karhunen <[email protected]>
Date: Tue, 21 Apr 2020 09:45:23 +0300
Subject: [PATCH] KVM: external hypervisor for imx8qmmek 5.10.72 kernel
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this apply to the newer 5.15.32 kernel we updated yesterday? 60ddbbe

@@ -553,7 +556,7 @@ in {
ref = "lf_v2022.04-uefi";
};
patches = [
./0001-imx8qm-uefi.patch
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please sync with @panufi on if just replacing is even an option

stdenv.mkDerivation ({

name = "kvms";

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add comment on how and why binary blob is built from https://github.com/jkrh/kvms

Copy link
Collaborator

@vilvo vilvo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please address comments. Also, testing needed. Thanks for the work so far - development builds can be built from your forks.

nxp's repo sha: fa6c3168

Signed-off-by: Grigoriy Romanov <[email protected]>
In a case when kvms binary is not presented on boot partition
uboot will just notify about that and will continue to load
device tree blob and linux image. lack of bl1.bin file dont
block boot process.

Signed-off-by: Grigoriy Romanov <[email protected]>
was removed hence that changes already in imx8-uboot repo.

Signed-off-by: Grigoriy Romanov <[email protected]>
from my personal github account. There are binary images for
imx8qxp and imx8qm boards.

Signed-off-by: Grigoriy Romanov <[email protected]>
* Linux kernel patch for 5.15.32
* Kernel patch file for 5.10.72 was renamed
* kvms binaries for 5.15.32 kernel were added to external github
  repo, related package updated
* tiny clean up in uboot files

Signed-off-by: Grigoriy Romanov <[email protected]>
@grihey grihey force-pushed the aarch64-imx8-crosscompile-kvms branch from cdb64ad to 8b8b4d4 Compare September 19, 2022 13:50
When kvms for 5.15 kernel take place, vCPU has a rised
KVM_ARM_VCPU_PMU_V3 bit in features description during
its creation. Te fact leads to return from kvm_vcpu_ioctl()
handler with error code -EINVAL.

Problem was resolved by forcely make pmu presence check
in vCPU to zero (lack of pmu). its hackish, but works.

Signed-off-by: Grigoriy Romanov <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants